Improve pyrex cython linter. #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like many other linters, use variables for the executable and options used by the linter. By default, the linter now report every warnings as errors with `--warning-errors`. Also add include directory and set working directory to file directory.
w0rp
requested changes
Jun 25, 2018
ale_linters/pyrex/cython.vim
Outdated
| " Description: cython syntax checking for cython files. | ||
|
|
||
| call ale#Set('pyrex_cython_executable', 'cython') | ||
| call ale#Set('pyrex_cython_options', '--warning-extra --warning-errors') |
There was a problem hiding this comment.
Could you remove --warning-errors here, so we can preserve the current behavior? If users want warnings to be errors, they can change the option themselves. I don't want to change the behavior without a very compelling reason, and whether warnings should be errors is subjective.
Add a custom handler to support cython warning format. Remove '--warning-errors' to keep previous behaviour.
w0rp
reviewed
Jun 25, 2018
Add common callback tests to check if executable and options are well configurable.
|
Done |
w0rp
approved these changes
Jun 27, 2018
|
Good stuff. 👍 Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like many other linters, use variables for the executable and options
used by the linter.
By default, the linter now report every warnings as errors with
--warning-errors.Also add include directory and set working directory to file directory.